Mutation of OrderedDict iterator during the loop #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
base_relation.pydeletemethod, we modify the content of the OrderedDictrelationswhile traversing using itsvalues()iterator, thus modifying the iterator!datajoint-python/datajoint/base_relation.py
Lines 360 to 367 in 25dff09
It turns out that modification of the OrderedDict iterator is OK in Python 3.4 (although still not recommended) but simply fails in Python 3.5. The code has been fixed such that we are no longer using direct iterator if the OrderedDict is to be modified in the loop.
I also added Python 3.5 to the test target platform for Travis CI, addressing #198