Rearrange logic in Table and Base #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/datajoint/datajoint-python: insert supports blobs before converting insert to placeholders
fabiansinz
added a commit
that referenced
this pull request
May 8, 2015
Rearrange logic in Table and Base
This was referenced May 8, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rearranged methods in Table and Base such that most of the declaration related logic is now found in the Table class. Ability to resolve module names are provided by Base through the use of overridden method
get_base.I have also added quite a few test cases covering various scenarios of using Base derivatives including referencing across schema, and referencing a schema bound to a package.