Skip to content

Conversation

@CBroz1
Copy link
Contributor

@CBroz1 CBroz1 commented Oct 14, 2022

Sorry - this should have been in the previous PR. I failed to check if the .github dir had been updated with the most recent versions

@kabilar kabilar self-assigned this Oct 14, 2022
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CBroz1. Looking at element-calcium-imaging, it doesn't seem that some of these files are required.

@CBroz1
Copy link
Contributor Author

CBroz1 commented Oct 14, 2022

Thanks @CBroz1. Looking at element-calcium-imaging, it doesn't seem that some of these files are required.

Does element-calcium-imaging PyPI publish with a tag? I think what you lined to is the old version

The reason I noticed in this case was because I pushed a tag and it didn't trigger the gh-action

@kabilar
Copy link
Collaborator

kabilar commented Oct 14, 2022

@CBroz1 Oops, I linked to element-array-ephys, but it also has the fewer files. Not sure what is the latest. But yes, we pushed a tag today to element-calcium-imaging and it triggered a pypi release. If you pushed a tag today, it won't trigger the GHActions because there is already a release.

@CBroz1
Copy link
Contributor Author

CBroz1 commented Oct 14, 2022

Ok - just pushed a commit to remove the shell scripts and the staging dir

@kabilar
Copy link
Collaborator

kabilar commented Oct 17, 2022

Thanks @CBroz1. Will we also need the development.yaml file?

@kushalbakshi
Copy link
Collaborator

The element-calcium-imaging GHActions has a development.yaml file. I think it's necessary to trigger GHActions, but it doesn't need to be changed in any way. You can just add it to the workflows directory

@kabilar
Copy link
Collaborator

kabilar commented Oct 17, 2022

Just confirmed with Drew that we do not need the development.yaml file.

@kabilar kabilar merged commit a2d2c94 into datajoint:main Oct 17, 2022
@kabilar
Copy link
Collaborator

kabilar commented Oct 17, 2022

@CBroz1 Please tag and push the tag to upstream to trigger a release. Thank you.

@CBroz1
Copy link
Contributor Author

CBroz1 commented Oct 18, 2022

Hi @kabilar - I just discussed with Raphael who stressed the need for the .staging directory and .sh files. We'll need to re-add with the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants