Skip to content

Loader and Trigger for EXTRACT #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Dec 14, 2022
Merged

Loader and Trigger for EXTRACT #65

merged 29 commits into from
Dec 14, 2022

Conversation

@tdincer
Copy link
Contributor

@tdincer tdincer commented Dec 1, 2022

Key Functions:

  • compose a Matlab script to define an EXTRACT analysis
  • trigger EXTRACT analysis in Matlab from python.
  • load the EXTRACT analysis results.

@kabilar kabilar self-assigned this Dec 13, 2022
@tdincer tdincer changed the title Introduce extract_utils.py Loader and Trigger for EXTRACT Dec 14, 2022
@tdincer tdincer marked this pull request as ready for review December 14, 2022 01:15
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
@tdincer
Update element_interface/extract_loader.py
d2eb1e8 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
tdincer and others added 2 commits December 14, 2022 14:17
@tdincer
Update element_interface/extract_loader.py
2ab366d 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
Update element_interface/extract_loader.py
e3ff2ad 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
tdincer and others added 6 commits December 14, 2022 14:18
@tdincer
Update element_interface/extract_loader.py
c18aa11 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
Update element_interface/extract_trigger.py
e5ed418 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
Update element_interface/extract_loader.py
d93c2de 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
Update element_interface/extract_loader.py
3517d13 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
Update element_interface/extract_trigger.py
1796c52 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
Update element_interface/extract_trigger.py
8554cc3 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
@tdincer
Update element_interface/extract_trigger.py
bca1a5a 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@kabilar
Copy link
Collaborator

kabilar commented Dec 14, 2022

Do we need to add the matlab engine to requirements.txt or just update the Element Calcium Imaging tutorial docs?

kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar reviewed Dec 14, 2022
View reviewed changes
kabilar
kabilar requested changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tdincer! Great work. A few suggestions above.

tdincer and others added 5 commits December 14, 2022 15:05
@tdincer
Update element_interface/extract_trigger.py
bb1f15f 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
Update element_interface/extract_trigger.py
1bf75cc 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
Update element_interface/extract_loader.py
0b5dc06 
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@tdincer
final touches
e03c967
@tdincer
Merge branch 'main' of https://github.com/tdincer/element-interface
1583e02
kabilar
kabilar approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tdincer!

@kabilar kabilar merged commit 0b7da1d into datajoint:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kabilar kabilar kabilar approved these changes

Assignees

@kabilar kabilar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tdincer @kabilar