-
Notifications
You must be signed in to change notification settings - Fork 17
Fix multiple z device ingestion in prairieviewreader.py
#78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
kabilar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushalbakshi Thanks for the joint coding session today. We are close to merging. We just need to handle the case when the same z depth is used by both controllers.
kabilar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kushalbakshi!
This PR addresses issue #77.
The updated code was used to ingest 3 different versions of
.xmlmetadata files into theScanInfoandScanInfo.Fieldtables from DataJoint Element Calcium Imaging. Version 1 and 2 contained two z-axis controllers at different "subindex" locations in the.xmlfile. Version 3 contained only 1 z-axis coordinate which did not change during the acquisition. All 3 ingestions completed without errors and populated all the attributes correctly.In this PR I perform the following:
.xmlmetadata file.xmlfiles available to me as of this PR.ScanInfoandScanInfo.FieldScreenshot of test schema ingestion:
