Skip to content

Conversation

@kushalbakshi
Copy link
Collaborator

@kushalbakshi kushalbakshi commented Mar 15, 2023

This PR addresses issue #77.

The updated code was used to ingest 3 different versions of .xml metadata files into the ScanInfo and ScanInfo.Field tables from DataJoint Element Calcium Imaging. Version 1 and 2 contained two z-axis controllers at different "subindex" locations in the .xml file. Version 3 contained only 1 z-axis coordinate which did not change during the acquisition. All 3 ingestions completed without errors and populated all the attributes correctly.

In this PR I perform the following:

  • Update code to handle multiple z-devices in PrairieView's .xml metadata file
  • Test the code to verify ingestion runs successfully for the user who created the issue
  • Test the code to verify ingestion runs successfully for other versions of .xml files available to me as of this PR.
  • Attach screenshots of successful ingestion of ScanInfo and ScanInfo.Field
  • Update CHANGELOG
  • Update version.py

Screenshot of test schema ingestion:
image

@kushalbakshi kushalbakshi added the bug Something isn't working label Mar 15, 2023
@kushalbakshi kushalbakshi linked an issue Mar 15, 2023 that may be closed by this pull request
@kushalbakshi kushalbakshi requested a review from kabilar March 15, 2023 22:41
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@kushalbakshi kushalbakshi requested a review from kabilar March 16, 2023 14:37
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@kushalbakshi kushalbakshi requested a review from kabilar March 16, 2023 18:22
kushalbakshi and others added 5 commits March 16, 2023 14:50
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@kushalbakshi kushalbakshi requested a review from kabilar March 16, 2023 19:51
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushalbakshi Thanks for the joint coding session today. We are close to merging. We just need to handle the case when the same z depth is used by both controllers.

@kushalbakshi kushalbakshi requested a review from kabilar April 6, 2023 21:52
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushalbakshi!

@kabilar kabilar merged commit 068b749 into datajoint:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple z devices (PrairieView metadata reader)

2 participants