Skip to content

Conversation

@kushalbakshi
Copy link
Collaborator

@kushalbakshi kushalbakshi commented Jul 26, 2023

This PR will make the following changes for the current prairieviewreader.py:

  • Update internal variable names to be more descriptive of their function.
  • Update docstrings within the function and add comments to make the function more readable where appropriate.
  • Once above changes are approved, the file name prairieviewreader.py will be changed to prairie_view_loader.py to reflect the file names of the other loaders within element-interface.
  • Update CHANGELOG.
  • Update version.py.
  • Release tag to PyPI after merge.
  • Update these lines in scan.py in element-calcium-imaging to reflect the updated file name.
  • Update key / value pairs where needed in these lines of scan.py in element-calcium-imaging.

@kabilar
Copy link
Collaborator

kabilar commented Jul 26, 2023

  • Once above changes are approved, the file name prairieviewreader.py will be changed to prairie_view_loader.py to reflect the file names of the other loaders within element-interface.

Please use git mv to rename this file.

Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushalbakshi. A few minor suggestions above.

kushalbakshi and others added 2 commits July 26, 2023 12:39
@kushalbakshi kushalbakshi requested a review from kabilar July 26, 2023 17:44
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@kushalbakshi kushalbakshi requested a review from kabilar July 27, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants