Skip to content

i frame component#92

Merged
guzman-raphael merged 24 commits intodatajoint:mainfrom
A-Baji:iframe-component
Apr 13, 2023
Merged

i frame component#92
guzman-raphael merged 24 commits intodatajoint:mainfrom
A-Baji:iframe-component

Conversation

@A-Baji
Copy link
Copy Markdown
Collaborator

@A-Baji A-Baji commented Mar 7, 2023

image

@A-Baji A-Baji linked an issue Mar 7, 2023 that may be closed by this pull request
@A-Baji A-Baji requested a review from guzman-raphael March 8, 2023 21:23
@A-Baji A-Baji requested a review from guzman-raphael March 13, 2023 21:21
Copy link
Copy Markdown
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A-Baji Great work! 💪

Here is an idea that I think would be an improvement to prevent unnecessary noise in API calls.

@A-Baji A-Baji temporarily deployed to docker April 13, 2023 17:47 — with GitHub Actions Inactive
@A-Baji A-Baji temporarily deployed to docker April 13, 2023 17:50 — with GitHub Actions Inactive
@A-Baji A-Baji requested a review from guzman-raphael April 13, 2023 17:52
Copy link
Copy Markdown
Collaborator

@guzman-raphael guzman-raphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A-Baji Looking good! 😎

@A-Baji A-Baji temporarily deployed to docker April 13, 2023 20:58 — with GitHub Actions Inactive
@guzman-raphael guzman-raphael merged commit d316415 into datajoint:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iframe component

2 participants