Conversation
❌ Deploy Preview for datalayer-core failed.
|
There was a problem hiding this comment.
Pull request overview
This PR focuses on unblocking build/runtime issues for the CLI login bundle and improving authentication UX flows, while reducing unnecessary JupyterLab-related bundle weight in standalone builds.
Changes:
- Extend
vite.cli-login.config.tsto better handle raw asset imports (.raw.css,.whl,.lexical) and CommonJS interop for the CLI login build. - Enhance sign-in components with richer UX (provider-specific loading indicators, disabled states, password toggle flow, MFA validation flow) and more configuration options.
- Lazy-load heavy JupyterLab/Jupyter React dependencies in
useToastto keep standalone bundles lighter.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
vite.cli-login.config.ts |
Adds build-time plugins and dependency optimization rules to fix asset/query handling in the CLI login bundle. |
src/views/iam/SignInSimple.tsx |
Expands the sign-in UI/behavior (social loading indicators, password form toggle, MFA validation, configurable labels/links/layout). |
src/hooks/useToast.tsx |
Lazily loads JupyterLab-related dependencies and gates Notification usage behind a runtime-loaded API handle. |
src/hooks/useJupyterLabTheme.tsx |
Uses a type-only import for IThemeManager to avoid runtime dependency coupling. |
src/components/auth/LoginToken.tsx |
Adds disabled prop to prevent token login interactions during other in-flight login flows. |
src/components/auth/Login.tsx |
Adds social sign-in spinners/disabled states and refactors callback URI generation + social sign-in initiation. |
README.md |
Updates the main header text. |
.gitignore |
Ignores static build output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+127
to
+132
| : location.protocol + | ||
| '//' + | ||
| location.hostname + | ||
| ':' + | ||
| location.port + | ||
| iamProvider.oauth2CallbackUIRoute; |
Comment on lines
+247
to
+255
| const startOAuthSignIn = (providerSpec: IIAMProviderSpec) => { | ||
| if (getOAuth2URLMutation.isPending) { | ||
| return; | ||
| } | ||
| setPendingOAuthProvider(providerSpec.name); | ||
| const queryArgs: Record<string, string> = { | ||
| provider: providerSpec.name, | ||
| callback_uri: buildCallbackURI(providerSpec), | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.