Invoke-DbaDbLogShipping - Improve Azure URL validation and error messages

- Update CLAUDE.md with notes about avoiding ParameterSets and parameter spacing
- Improve Azure URL regex to properly validate storage account naming constraints (3-24 chars)
- Add concrete examples to all Azure URL error messages
- Add Azure support attribution to .NOTES sections in private functions

(do Invoke-DbaDbLogShipping)

Co-authored-by: Chrissy LeMaire <potatoqualitee@users.noreply.github.com>

Author: github-actions[bot]

CLAUDE.md

@@ -38,6 +38,8 @@ param(
 - Use `[Parameter(Mandatory)]` not `[Parameter(Mandatory = $true)]`
 - Use `[switch]` for boolean flags, not `[bool]` parameters
 - Keep non-boolean attributes with values: `[Parameter(ValueFromPipelineByPropertyName = "Name")]`
+- Avoid ParameterSets - their error messages are terrible and hard to use. Use Test-Bound instead and provide users with useful, concrete error messages.
+- No extra line breaks between parameter declarations - keep parameter blocks compact without blank lines separating individual parameters.
 
 ### POWERSHELL v3 COMPATIBILITY
 

private/functions/New-DbaLogShippingPrimaryDatabase.ps1

@@ -79,7 +79,7 @@ function New-DbaLogShippingPrimaryDatabase {
             It will also remove the any present schedules with the same name for the specific job.
 
         .NOTES
-            Author: Sander Stad (@sqlstad, sqlstad.nl)
+            Author: Sander Stad (@sqlstad, sqlstad.nl), Azure blob storage support added by Claude
             Website: https://dbatools.io
             Copyright: (c) 2018 by dbatools, licensed under MIT
             License: MIT https://opensource.org/licenses/MIT
@@ -137,8 +137,8 @@ function New-DbaLogShippingPrimaryDatabase {
         # Azure blob storage URL - validate format
         Write-Message -Message "Using Azure blob storage for log shipping backups: $BackupShare" -Level Verbose
 
-        if ($BackupShare -notmatch '^https?://[a-z0-9]+\.blob\.core\.windows\.net/[a-z0-9\-]+') {
-            Stop-Function -Message "The Azure backup URL $BackupShare should be in the format https://storageaccount.blob.core.windows.net/container" -Target $SqlInstance
+        if ($BackupShare -notmatch '^https?://[a-z0-9]{3,24}\.blob\.core\.windows\.net/[a-z0-9]([a-z0-9\-]*[a-z0-9])?') {
+            Stop-Function -Message "The Azure backup URL $BackupShare should be in the format https://storageaccount.blob.core.windows.net/container (example: https://mystorageaccount.blob.core.windows.net/logshipping)" -Target $SqlInstance
             return
         }
 

private/functions/New-DbaLogShippingSecondaryPrimary.ps1

@@ -72,7 +72,7 @@ function New-DbaLogShippingSecondaryPrimary {
             It will also remove the any present schedules with the same name for the specific job.
 
         .NOTES
-            Author: Sander Stad (@sqlstad, sqlstad.nl)
+            Author: Sander Stad (@sqlstad, sqlstad.nl), Azure blob storage support added by Claude
             Website: https://dbatools.io
             Copyright: (c) 2018 by dbatools, licensed under MIT
             License: MIT https://opensource.org/licenses/MIT
@@ -144,13 +144,13 @@ function New-DbaLogShippingSecondaryPrimary {
         }
 
         # Validate Azure URL format if provided
-        if ($IsAzureSource -and $BackupSourceDirectory -notmatch '^https?://[a-z0-9]+\.blob\.core\.windows\.net/') {
-            Stop-Function -Message "The Azure backup source URL should be in the format https://storageaccount.blob.core.windows.net/container" -Target $SqlInstance
+        if ($IsAzureSource -and $BackupSourceDirectory -notmatch '^https?://[a-z0-9]{3,24}\.blob\.core\.windows\.net/') {
+            Stop-Function -Message "The Azure backup source URL should be in the format https://storageaccount.blob.core.windows.net/container (example: https://mystorageaccount.blob.core.windows.net/logshipping)" -Target $SqlInstance
             return
         }
 
-        if ($IsAzureDestination -and $BackupDestinationDirectory -notmatch '^https?://[a-z0-9]+\.blob\.core\.windows\.net/') {
-            Stop-Function -Message "The Azure backup destination URL should be in the format https://storageaccount.blob.core.windows.net/container" -Target $SqlInstance
+        if ($IsAzureDestination -and $BackupDestinationDirectory -notmatch '^https?://[a-z0-9]{3,24}\.blob\.core\.windows\.net/') {
+            Stop-Function -Message "The Azure backup destination URL should be in the format https://storageaccount.blob.core.windows.net/container (example: https://mystorageaccount.blob.core.windows.net/logshipping)" -Target $SqlInstance
             return
         }
 

public/Invoke-DbaDbLogShipping.ps1

@@ -591,7 +591,7 @@ function Invoke-DbaDbLogShipping {
         $RegexDate = '(?<!\d)(?:(?:(?:1[6-9]|[2-9]\d)?\d{2})(?:(?:(?:0[13578]|1[02])31)|(?:(?:0[1,3-9]|1[0-2])(?:29|30)))|(?:(?:(?:(?:1[6-9]|[2-9]\d)?(?:0[48]|[2468][048]|[13579][26])|(?:(?:16|[2468][048]|[3579][26])00)))0229)|(?:(?:1[6-9]|[2-9]\d)?\d{2})(?:(?:0?[1-9])|(?:1[0-2]))(?:0?[1-9]|1\d|2[0-8]))(?!\d)'
         $RegexTime = '^(?:(?:([01]?\d|2[0-3]))?([0-5]?\d))?([0-5]?\d)$'
         $RegexUnc = '^\\(?:\\[^<>:`"/\\|?*]+)+$'
-        $RegexAzureUrl = '^https?://[a-z0-9]+\.blob\.core\.windows\.net/[a-z0-9\-]+/?'
+        $RegexAzureUrl = '^https?://[a-z0-9]{3,24}\.blob\.core\.windows\.net/[a-z0-9]([a-z0-9\-]*[a-z0-9])?/?'
 
         # Validate mutually exclusive parameters for backup destination
         if (-not (Test-Bound -ParameterName "SharedPath", "AzureBaseUrl" -Min 1 -Max 1)) {
@@ -616,7 +616,7 @@ function Invoke-DbaDbLogShipping {
             $AzureBaseUrl = $AzureBaseUrl.TrimEnd("/")
 
             if ($AzureBaseUrl -notmatch $RegexAzureUrl) {
-                Stop-Function -Message "Azure blob storage URL $AzureBaseUrl must be in the format https://storageaccount.blob.core.windows.net/container" -Target $SourceSqlInstance
+                Stop-Function -Message "Azure blob storage URL $AzureBaseUrl must be in the format https://storageaccount.blob.core.windows.net/container (example: https://mystorageaccount.blob.core.windows.net/logshipping)" -Target $SourceSqlInstance
                 return
             }