Lindat9/Update pipeline in GA - #1386
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions pipeline to target the LINDAT-9 environment (dev-6 / instance 8603) and to automatically run UI + REST verification after deployments.
Changes:
- Update the Playwright test workflow to point at the dev-6 / 8603 endpoint and new instance name.
- Extend the Docker image workflow to trigger the deploy reusable workflow after image build (non-PR events only).
- Add post-deploy and post-import Playwright + REST test jobs to the deploy workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/playwright-tests.yml | Updates the Playwright test target URL/name and removes customer-config copying steps. |
| .github/workflows/docker.yml | Adds a deploy job that calls the reusable deploy workflow after the image build. |
| .github/workflows/deploy.yml | Adds post-deploy/import Playwright and REST test trigger/watch jobs for instance 8603. |
milanmajchrak
added a commit
that referenced
this pull request
Jul 21, 2026
…9 base (#1389) * Make Solr heap tunable via SOLR_HEAP in docker-compose-rest.yml (default 4g) Manual re-apply (ADAPT) of dtq-dev commit d8c5d54: the fork hunk edited the 7.6 compose entrypoint line ('exec solr -p 8983 -f -m 4g') which no longer exists on the vanilla 9_x entrypoint ('runuser -u solr -- solr-foreground'). Applied as an environment block entry SOLR_HEAP: "${SOLR_HEAP:-4g}" on the dspacesolr service - the official solr:9-based dspace-solr image's solr-foreground honors SOLR_HEAP and runuser without -l preserves the environment. Quotes kept per the fork squash ('Add Solr params into quotes'). Per-instance override works via deploy.yml's --env-file /opt/dspace-envs/$INSTANCE. Fulfils CLARIN_V9_POST_SNAPSHOT_SYNC_ACCEPTANCE.md par.5 / d8c5d54 (FE-1, Vlna 1). * Pass PASSWORD_ADMIN secret to Playwright UI tests (remainder of #1372 port) Port remainder (ADAPT) of dtq-dev commit af0c70f: the functional core of that commit - removing the broken 'Copy customer config' step referencing the absent config/config.lindat.ui.tests.json - was already applied on dtq-dev-9-base by the newer v9-side commit c22bfa0 (Lindat9/Update pipeline in GA, #1386), which also retargeted HOME_URL to dev-6.pc:8603 and set NAME: LINDAT-9 (the lindat-9 profile exists in dspace-ui-tests/customer-constants/customers/). Those newer v9-side choices are deliberately kept: NAME stays LINDAT-9, NOT the fork's DEFAULT. The only fork delta still missing was PASSWORD_ADMIN: dspace-ui-tests/scripts/test.sh forwards PASSWORD_ADMIN into the test container (login-dependent specs), so this commit adds it from the existing DSPACE_ADMIN_PASSWORD repo secret. Deviation from the sync plan card af0c70f recorded: AC2 (byte parity with fork head playwright-tests.yml) is obsolete due to target-branch drift (#1386-#1388); disposition changes PORT -> ADAPT/partially-superseded. Fulfils CLARIN_V9_POST_SNAPSHOT_SYNC_ACCEPTANCE.md par.5 / af0c70f (FE-1, Vlna 1), with documented AC deviations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Introduce playwright and rest tests after deploy and docker images
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review