Skip to content

fix: increase timeout and retry settings for transport configuration #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shackmann merged 1 commit into from
Jul 28, 2026
+14 −14
Merged

fix: increase timeout and retry settings for transport configuration #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@ deployment:
# model_version: jointfm-inference:0.2.0+ckpt.fin-2026-05-22
transport:
timeout:
connect_seconds: 5.0
read_seconds: 60.0
connect_seconds: 10.0
read_seconds: 120.0
retry:
max_attempts: 5
backoff_seconds: 1
max_attempts: 10
backoff_seconds: 2
```

Equivalent `.env` deployment configuration:
Expand Down
8 changes: 4 additions & 4 deletions config.sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ deployment:
model_version: null
transport:
timeout:
connect_seconds: 5.0
read_seconds: 60.0
connect_seconds: 10.0
read_seconds: 120.0
retry:
max_attempts: 5
backoff_seconds: 1
max_attempts: 10
backoff_seconds: 2
max_backoff_seconds: 60.0
status_codes:
- 408
Expand Down
8 changes: 4 additions & 4 deletions src/jointfm_client/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ def to_environment_values(
class TimeoutConfig(_ConfigModel):
"""Default connect and read timeout values for HTTP requests."""

connect_seconds: float = 5.0
read_seconds: float = 60.0
connect_seconds: float = 10.0
read_seconds: float = 120.0

@field_validator("connect_seconds", "read_seconds")
@classmethod
Expand All @@ -144,8 +144,8 @@ def _validate_positive_finite(cls, value: float) -> float:
class RetryConfig(_ConfigModel):
"""Default retry policy for transient HTTP failures."""

max_attempts: int = 5
backoff_seconds: float = 1
max_attempts: int = 10
backoff_seconds: float = 2
max_backoff_seconds: float = 60.0
status_codes: tuple[int, ...] = (408, 429, 500, 502, 503, 504)

Expand Down
4 changes: 2 additions & 2 deletions tests/test_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ def test_load_configuration_layers_yaml_over_defaults(tmp_path: Path) -> None:
assert config.deployment.datarobot_endpoint == "https://app.datarobot.com/api/v2"
assert config.deployment.datarobot_api_token == "yaml-token"
assert config.transport.timeout.connect_seconds == 1.25
assert config.transport.timeout.read_seconds == 60.0
assert config.transport.timeout.read_seconds == 120.0
assert config.transport.retry.max_attempts == 2
assert config.transport.retry.backoff_seconds == 1
assert config.transport.retry.backoff_seconds == 2
assert config.transport.retry.status_codes == (500,)


Expand Down
Loading