Skip to content

Fixed dstapply. Not all the parent.frames() are needed#43

Merged
OllyButters merged 1 commit into
datashield:v6.0-devfrom
tombisho:v6.0-dev-tapply
Feb 14, 2020
Merged

Fixed dstapply. Not all the parent.frames() are needed#43
OllyButters merged 1 commit into
datashield:v6.0-devfrom
tombisho:v6.0-dev-tapply

Conversation

@tombisho

Copy link
Copy Markdown
Contributor

Hi,

I have used my recent learning to update tapplyDS to work correctly with environments. I hope this helps!

Tom

@OllyButters

Copy link
Copy Markdown
Member

@tombisho - did you mean to edit all those man pages?

@tombisho

Copy link
Copy Markdown
Contributor Author

@OllyButters no I didn't mean to change them, they were just automatically generated like that when I built the package. If it is important I can go back and try and work out how to stop this happening? Or can you somehow block that as part of the merge?

@StuartWheater

Copy link
Copy Markdown
Member

I can confirm new tapplyDS.R passes smoke tests when configured with both driver the "DSLiteDriver" and "OpalDriver".

@OllyButters

Copy link
Copy Markdown
Member

Actually, I didn't give you enough credit @tombisho - your updated man pages bring them inline with the other existing man pages. Good tidy up skills!

@OllyButters
OllyButters merged commit 05a3a51 into datashield:v6.0-dev Feb 14, 2020
@tombisho
tombisho deleted the v6.0-dev-tapply branch February 14, 2020 14:44
@tombisho

Copy link
Copy Markdown
Contributor Author

Actually, I didn't give you enough credit @tombisho - your updated man pages bring them inline with the other existing man pages. Good tidy up skills!

That was definitely what I was trying to do and it didn't just happen by mistake

StuartWheater added a commit that referenced this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants