Mount the quota credential as cert files plus a static kubeconfig#169
Merged
Conversation
Change the compute-manager quota-credentials volume from a single opaque secret to a projected volume that combines the Milo client certificate (compute-edge-milo-client-cert) with a static kubeconfig ConfigMap (compute-quota-kubeconfig), both supplied by the cluster environment. compute-manager now loads a kubeconfig that references the mounted cert files by path instead of one with the client key embedded, so cert rotation is a plain file refresh and no secret carries an assembled kubeconfig. Both sources are optional, so the manager still starts where quota is not wired. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ecv
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Changes the compute-manager quota-credentials volume from a single opaque secret to a projected volume that combines the Milo client certificate with a static kubeconfig ConfigMap, both supplied by the cluster environment. compute-manager loads a kubeconfig that references the mounted cert files by path instead of one with the client key embedded.
Why
Changes
config/components/quota-credentials: thequota-credentialsvolume becomes a projected volume over Secretcompute-edge-milo-client-cert+ ConfigMapcompute-quota-kubeconfig. Mount path andquotaKubeconfigPathare unchanged.Related