fix: pin both images via the bundle publish's new images: input - #217
Merged
Conversation
Confirmed live in staging: ImagePullBackOff, image not found. The publish-docker.yaml reusable workflow never pushes a :latest tag — its tag scheme is v0.0.0-main[-<timestamp>]/semver/sha only (checked its docker/metadata-action config directly). v0.0.0-main is the actual floating tag that gets overwritten on every push to main.
v1.20.0 of publish-kustomize-bundle.yaml added an images: input
(multiple {path, name, tag} entries in one invocation) — supersedes the
single image-name/image-overlays pair, which can only stamp one image
across N paths and can't express two different images at two different
paths at all. That's the real fix for the floating-tag workaround in the
previous commit: both compute's own apiserver image and the
consumer-ui-plugin's image now get properly pinned to immutable tags in
one compute-kustomize bundle publish, instead of the plugin falling back
to an unpinned v0.0.0-main.
Bumped this job's pin to v1.20.0 to match (was v1.14.0). compute's own
image entry omits an explicit tag, preserving its existing behavior
(defaults to the bundle's own first computed tag, unchanged from
before); the plugin's entry pins to publish-consumer-ui-plugin-image's
actual output tag.
Verified locally: kustomize edit set image works correctly against a
kind: Component kustomization (not just kind: Kustomization), and the
full compute-manager composition (base/manager + all its components)
still builds cleanly with both image references present.
kevwilliams
changed the title
scotwells
requested changes
Aug 11, 2026
| bundle-name: ghcr.io/datum-cloud/compute-kustomize | ||
| bundle-path: config | ||
| images: | | ||
| - { path: config/base/manager, name: ghcr.io/datum-cloud/compute } |
Contributor
There was a problem hiding this comment.
@kevwilliams need to add the same tag configuration here.
| containers: | ||
| - name: compute-consumer-ui-plugin | ||
| image: ghcr.io/datum-cloud/compute-consumer-ui-plugin:latest | ||
| image: ghcr.io/datum-cloud/compute-consumer-ui-plugin:v0.0.0-main |
Contributor
There was a problem hiding this comment.
Leave this to :latest by default.
…to :latest
Per review:
- Added tag: "${{ needs.publish-container-image.outputs.tag }}" to
compute's images: entry, matching the plugin's entry — explicit
rather than relying on the "defaults to the bundle's own first
computed tag" fallback.
- Reverted the Deployment's base image tag to :latest — it's a
never-actually-deployed placeholder now that images: always
overwrites it via kustomize edit set image before the bundle
publishes; :latest reads clearly as "gets stamped, don't rely on
this literal value."
scotwells
approved these changes
Aug 11, 2026
scotwells
left a comment
scotwells
left a comment
Contributor
There was a problem hiding this comment.
Comment seems a bit verbose, but :approved:
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute-consumer-ui-pluginpods stuck inImagePullBackOffin staging.ghcr.io/datum-cloud/compute-consumer-ui-plugin:latestdoesn't exist —publish-docker.yamlnever pushes a:latesttag.First commit: floating
v0.0.0-maintag as a quick fix.Second commit: the real fix.
publish-kustomize-bundle.yaml@v1.20.0added animages:input — multiple{path, name, tag}entries per invocation. Supersedesimage-name/image-overlays, which stamps one image across N paths and can't pin two different images at two different paths. Bumped the pin fromv1.14.0tov1.20.0, switched toimages:. Bothcompute's apiserver image and the plugin's image now get immutable tags in onecompute-kustomizebundle publish.Test plan
docker manifest inspect ghcr.io/datum-cloud/compute-consumer-ui-plugin:v0.0.0-mainresolveskustomize edit set imageworks against akind: Componentkustomization, not justkind: Kustomizationcompute-managercomposition (base/manager+ all its components) builds with both image references presentRunning, notImagePullBackOff; both images carry immutable tags in the published bundle