Skip to content

feat(grouped-table): data-table style parity + slot className overrides#121

Merged
yahyafakhroji merged 1 commit into
mainfrom
feat/grouped-table-style-parity
Jun 10, 2026
Merged

feat(grouped-table): data-table style parity + slot className overrides#121
yahyafakhroji merged 1 commit into
mainfrom
feat/grouped-table-style-parity

Conversation

@yahyafakhroji

@yahyafakhroji yahyafakhroji commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to the GroupedTable release — aligns GroupedTable's styling with data-table and adds slot-level className overrides.

  • Style parity: header/body/cells use the shared base table primitives like data-table; cell truncate removed (long content shows via the horizontal scroll, same as data-table).
  • Group band → section header: the collapsible band now reads as a muted sub-header (h-10, px-2, font-medium, text-muted-foreground, border-b) with a subtle bg-muted/40 fill so groups stay distinct.
  • Slot className API (mirrors data-table ContentProps): tableClassName, headerRowClassName, headerCellClassName, groupHeaderClassName (string | (group) => string), bodyClassName, rowClassName (string | (row) => string), cellClassName (string | (cell) => string), toolbarClassName. All optional, merged on top of defaults via cn().

Test plan

  • 41 unit tests pass (incl. new: string cellClassName on cells; groupHeaderClassName(group) on band)
  • typecheck clean · lint 0 errors · build emits dist
  • Visual pass in Storybook (light + dark): band-as-header + no-truncate confirmed
  • Optional reviewer eyeball in Storybook

Changeset: minor.

@yahyafakhroji yahyafakhroji self-assigned this Jun 9, 2026
@yahyafakhroji yahyafakhroji enabled auto-merge June 10, 2026 01:04
@yahyafakhroji yahyafakhroji merged commit f173450 into main Jun 10, 2026
8 checks passed
@yahyafakhroji yahyafakhroji deleted the feat/grouped-table-style-parity branch June 10, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants