fix(containerlab): give ns30/ns40 two attachments, not one shared - #313
Open
privateip wants to merge 1 commit into
Open
fix(containerlab): give ns30/ns40 two attachments, not one shared#313privateip wants to merge 1 commit into
privateip wants to merge 1 commit into
Conversation
This was referenced Aug 8, 2026
privateip
force-pushed
the
fix/vrf-shared-per-vpc-3-containerlab
branch
from
August 8, 2026 19:05
86e74e4 to
1be86f5
Compare
privateip
requested review from
0xmc,
scotwells and
slindseysr
and removed request for
drewr
August 8, 2026 19:13
Rebased onto the updated fix/vrf-shared-per-vpc-2-cnibgp (which picked up my own rebase-and-reconcile of that branch after fix/vrf-shared-per-vpc-1-core moved out from under it) after that branch's history moved out from under this one -- same ripple as #306 -> #307 -> #311 -> #312 -> #313. No conflicts: this PR only touches containerlab docs/scripts/ manifests, none of which overlapped with the Go source changes further up the stack. Applied cleanly. Verification: task lint, task build (all 8 binaries) pass on the rebased tree. No Go source changed in this PR, so task test:unit is unaffected. tests/e2e and the containerlab lab itself not run in this sandbox (no Kind cluster / root), same caveat as every PR in this stack. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
privateip
force-pushed
the
fix/vrf-shared-per-vpc-3-containerlab
branch
from
August 9, 2026 21:04
1be86f5 to
02ed3a1
Compare
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ns30/ns40 modeled "two pods, one VPC, one node" as one NAD scaled to two replicas, sharing a single attachment identifier — the setup that triggered the VRF collision fixed earlier in this stack. Each now gets its own NAD and Deployment with a distinct attachment under the same VPC, matching how every other tenant fixture models one attachment as one pod.
Test plan
task verifypasses end-to-end on a live containerlab lab, including ns30/ns40's two-attachment same-node pingsStack (merge bottom to top):
🤖 Generated with Claude Code