refactor: adjust verification flow to support upcoming registration loop#64
Merged
zachsmith1 merged 1 commit intoOct 8, 2025
Conversation
joshlreese
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the domain verification logic in
internal/controller/domain_controller.goto improve code organization and isolation. The main change is the extraction of verification-related operations into a new helper method, which centralizes verification attempts and status updates. Additionally, the status update logic and requeue scheduling have been streamlined to avoid redundant reconciles and improve maintainability.Refactoring and logic separation:
Reconcilefunction into a new helper methodreconcileVerification, which now handles verification attempts, status mutations, and computes the next verification time.Reconcilefunction now checks if the domain status has changed and updates it if necessary, then requeues based on the next scheduled verification attempt returned byreconcileVerification.Verification attempt handling:
Minor cleanups: