feat: wire domain controller with rdap registration#65
Merged
zachsmith1 merged 6 commits intoOct 15, 2025
Merged
Conversation
joshlreese
self-requested a review
October 14, 2025 22:09
joshlreese
approved these changes
Oct 14, 2025
joshlreese
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Left a few questions but nothing blocking a merge.
joshlreese
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to domain registration and nameserver modeling, as well as configuration enhancements for refresh and retry behavior. The changes clarify how authoritative nameservers are represented, refactor the registration data model, and add new configuration options for controlling registration data refresh intervals and backoff strategies.
Domain and Nameserver Modeling Improvements
NameserversandApexfields toDomainStatusto distinguish between apex domains and delegated subdomains, with clear rules for authoritative NS selection. (api/v1alpha/domain_types.go,config/crd/bases/networking.datumapis.com_domains.yaml)Nameserverto include a list ofNameserverIPobjects, which capture per-address provenance, and removed the directNameserversfield fromRegistration. (api/v1alpha/domain_types.go,api/v1alpha/zz_generated.deepcopy.go)Registration Data Model Updates
NextRegistrationAttemptfield toRegistrationto track when the next registration refresh should occur. (api/v1alpha/domain_types.go,api/v1alpha/zz_generated.deepcopy.go,config/crd/bases/networking.datumapis.com_domains.yaml)Configuration Enhancements
DomainRegistrationConfigto control RDAP/WHOIS refresh behavior, including refresh interval, retry backoff, jitter, and lookup timeout, with sensible defaults and deep copy support. (internal/config/config.go,internal/config/zz_generated.deepcopy.go,internal/config/zz_generated.defaults.go)Test and Default Handling
internal/controller/domain_controller_test.go,internal/config/zz_generated.defaults.go)