test: Hypothesis property tests + ty in CI (restore #31)#32
Merged
Conversation
Property-based tests for the pure functions that consume LLM judge output — the code whose real inputs are adversarial by nature: - parse_judge_output never raises on arbitrary text or arbitrary JSON (found a real crash: a truncated response consisting of a bare markdown fence raised IndexError; fixed here with regression examples) - _unswap_winner is an involution; ties are swap-invariant - aggregate_jury_votes: output shape, verdict validity, judge-order invariance, unanimity - compute_elo: covers all models, wins/losses balance, swap+winner double-flip leaves tallies unchanged Also finishes the half-done ty adoption: the three suppression comments in backends.py used mypy syntax (type: ignore[...]) which ty does not honor for its rule names — switched to ty: ignore[...] — and CI now runs 'uv run ty check src/' (ty was already a pinned dev dep). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
davanstrien
force-pushed
the
test/property-tests-and-ty-restore
branch
from
aa74e95 to
09de139
Compare
Newer huggingface_hub types the hardware param as SpaceHardware; the bare string fails ty. Runtime-equivalent (str enum). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #31 unchanged. It was approved and merged, but into its stacked base branch (
fix/jury-even-split-tie) rather than main — GitHub only retargets a stacked PR to main if the base branch is deleted when its PR merges, and it wasn't, so the content never reached main. Same commit, cherry-picked onto current main; 283 tests pass, ruff + ty clean, and this PR's CI will exercise the new ty step for real.See #31 for the full description and review.
🤖 Generated with Claude Code