Fix MCP and Companion version identities - #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
initializehandshake andhv_upgradedevelopmentfallbackCOMPANION_VERSIONinput while preserving the current combined release-number defaultWhy
The built MCP package was
0.1.3, but its MCP handshake still identified the server as0.1.0. The Companion client identity was hardcoded to the same stale value. These identities now come from their respective artifacts rather than hardcoded strings.Release impact
This does not bump a version or split the current release pipeline. Under the existing
vX.Y.Zworkflow, the MCP package and Companion still share a release number by default, but each reports its own authoritative identity. A future independent Companion release can passCOMPANION_VERSIONexplicitly.Checks
npm test— 104 files, 810 testsnpm run typechecknpm run buildinitializeandhv_upgradeboth report0.1.3npm run prepublish-checkswift test— 42 testsswift build -c release --product HypervibeCompanionbash -n scripts/build-macos-installer.shgit diff --check