Preserve imported service endpoints - #32
Merged
Merged
Conversation
davejohnson
marked this pull request as ready for review
July 26, 2026 05:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
HostingBindingsrecord.hv_healththrough the environment's declared domain when a web service has no provider URL binding.Root cause
Railway inspection collected per-environment service domains, but
importRailwayProjectpersisted only the service ID. As a result, a freshly adopted service appeared healthy in live observation while repo-backedhv_health service=webfailed withno URL binding.The health fallback was also binding-only even when the desired-state spec already declared the public domain.
Impact
Fresh adoption now produces reconstructible endpoint bindings. Health checks can also use a declared web domain consistently across hosting providers; Railway remains the current import source, but the stored shape and health behavior are provider-neutral.
Validation
vitest run --configLoader runner: 108 files, 885 tests passedtsc --noEmitnpm run buildhv_health service=webreturns HTTP 200 without an explicit URL