fix: drain pending batch after concurrent terminal, fix [object Objec…#86
Merged
Conversation
…t] title When a terminal tool was approved via approveToolRequest (concurrent path), non-terminal siblings like read_file stayed stuck as tool_request forever — _checkAndContinueAfterConcurrentResolution blindly set 'awaiting_user' instead of draining the remaining batch. Now calls _tryDrainPendingBatch so non-approval tools run automatically and only genuinely approval-required tools pause. Also fixes [object Object] in tool titles during running_now state when the tool was part of a batch. loadingTitleWrapper returns a React element, but the batch prefix path used template literal concatenation which stringified it. Now wraps in a fragment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t] title
When a terminal tool was approved via approveToolRequest (concurrent path), non-terminal siblings like read_file stayed stuck as tool_request forever — _checkAndContinueAfterConcurrentResolution blindly set 'awaiting_user' instead of draining the remaining batch. Now calls _tryDrainPendingBatch so non-approval tools run automatically and only genuinely approval-required tools pause.
Also fixes [object Object] in tool titles during running_now state when the tool was part of a batch. loadingTitleWrapper returns a React element, but the batch prefix path used template literal concatenation which stringified it. Now wraps in a fragment.