Initialise HTTPStream.app_put - #55
Merged
davidbrochart merged 1 commit intoJul 26, 2026
Merged
Conversation
It was only ever set once a request had been spawned, but StreamClosed reads it and can arrive first - the connection dying during the spawn is enough. The `is not None` guard there was already written as though it might be unset. Annotating it made the type checker point at the two call sites that use it without a guard, where a body cannot arrive before the request that opened the stream; both now say so. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lj1kTdm3gz4JB3bjeygDaK
davidbrochart
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was only ever set once a request had been spawned, but StreamClosed reads it and can arrive first - the connection dying during the spawn is enough. The
is not Noneguard there was already written as though it might be unset.Annotating it made the type checker point at the two call sites that use it without a guard, where a body cannot arrive before the request that opened the stream; both now say so.
Claude-Session: https://claude.ai/code/session_01Lj1kTdm3gz4JB3bjeygDaK