Flextable styling has regressed on pkgdown's vignette page

[atusy]

Since d732679 , including v0.9.0

• flextable's borders appear with wrong colors
• flextable's position is not centered

example

Following examples are produced by

• clone https://github.com/atusy/flextableDemo
• pkgdown::build_site()
• view http://.../flextableDemo/docs/articles/example.html

current

previous

Session Info

r$> sessionInfo()
R version 4.2.2 (2022-10-31)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Manjaro Linux

Matrix products: default
BLAS:   /usr/lib/libblas.so.3.11.0
LAPACK: /usr/lib/liblapack.so.3.11.0

locale:
 [1] LC_CTYPE=en_US.UTF-8    LC_NUMERIC=C            LC_TIME=C               LC_COLLATE=en_US.UTF-8  LC_MONETARY=C          
 [6] LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8    LC_NAME=C               LC_ADDRESS=C            LC_TELEPHONE=C         
[11] LC_MEASUREMENT=C        LC_IDENTIFICATION=C    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] flextable_0.8.7.004

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.10             prettyunits_1.1.1       ps_1.7.2                rprojroot_2.0.3         digest_0.6.31          
 [6] utf8_1.2.3              mime_0.12               R6_2.5.1                evaluate_0.20           pillar_1.8.1           
[11] gdtools_0.3.2           rlang_1.1.0             uuid_1.1-0              curl_5.0.0              rstudioapi_0.14        
[16] data.table_1.14.8       miniUI_0.1.1.1          whisker_0.4.1           callr_3.7.3             urlchecker_1.0.1       
[21] rmarkdown_2.20.1        pkgdown_2.0.7           textshaping_0.3.6       desc_1.4.2              devtools_2.4.5         
[26] stringr_1.5.0           htmlwidgets_1.6.1       shiny_1.7.4             compiler_4.2.2          httpuv_1.6.9           
[31] xfun_0.37               askpass_1.1             systemfonts_1.0.4       pkgconfig_2.0.3         pkgbuild_1.4.0         
[36] gfonts_0.2.0            htmltools_0.5.4         openssl_2.0.6           tibble_3.2.0            fontBitstreamVera_0.1.1
[41] httpcode_0.3.0          roxygen2_7.2.3          fansi_1.0.4             crayon_1.5.2            withr_2.5.0            
[46] later_1.3.0             grid_4.2.2              crul_1.3                jsonlite_1.8.4          xtable_1.8-4           
[51] lifecycle_1.0.3         magrittr_2.0.3          zip_2.2.2               cli_3.6.0               stringi_1.7.12         
[56] cachem_1.0.7            fs_1.6.1                promises_1.2.0.1        remotes_2.4.2           xml2_1.3.3             
[61] ragg_1.2.5              ellipsis_0.3.2          vctrs_0.5.2             tools_4.2.2             glue_1.6.2             
[66] officer_0.6.1           fontquiver_0.2.1        purrr_1.0.1             processx_3.8.0          pkgload_1.3.2          
[71] fastmap_1.1.1           yaml_2.3.7              fontLiberation_0.1.0    sessioninfo_1.2.2       memoise_2.0.1          
[76] knitr_1.42.4            profvis_0.3.7           usethis_2.1.6          

When submitting a new issue:

• Provide the code that is producing the error, it has to be a minimal reproducible example.
  Stackoverflow is providing good explanations about it: https://stackoverflow.com/help/mcve. You can use package reprex to help you: http://reprex.tidyverse.org/. The most popular R stackoverflow question is about the subject: https://stackoverflow.com/questions/5963269/how-to-make-a-great-r-reproducible-example.

• Provide the results of R command sessionInfo(). It had to be executed after you loaded the packages used by your example. This will let me know what is your version of R and what are the versions of the packages you used in your example.

• Make sure you did checked you had the latest version of the package on CRAN (and on github if issue exists with CRAN version).

• Make sure you searched in the open and closed issues on the github repository.

[davidgohel]

Hello @atusy

Sorry I can't find your example and I can't reproduce the issue. Do you have other information? On flextable pkgdown, all seems ok: https://davidgohel.github.io/flextable/reference/vline.html

[atusy]

@davidgohel

Oops, my bad. My repo was private. Now it is public and you can access.
I also deployed docs on GitHub pages.
So you can check it.

https://atusy.github.io/flextableDemo/articles/example.html

[davidgohel]

I see, it seems pkgdown drop html-dependencies from the vignette result. It certainly comes from recent changes made for Quarto (damn it, I probably to add another if)

It's weird – it's working with manuals but not in vignettes: see a flextable manual example - https://davidgohel.github.io/flextable/reference/add_footer_lines.html

[rempsyc]

I'm getting a similar issue for the nice_table vignette: https://rempsyc.remi-theriault.com/articles/table.html

Horizontal lines are added between each row across all tables now, and the grey background colouring is also lost. When I run the same code manually, everything looks perfect. As you say, most likely because pkgdown drops the html dependencies.

[davidgohel]

Sorry for the trouble!

It should be fixed now - the html dependancies were not a list as expected, this has been corrected and tested.

Le me know if I should re-open

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.