Add nr --version; bump release actions off deprecated Node 20 - #5
Merged
Conversation
- `nr --version` / `nr -V` print the version (from CARGO_PKG_VERSION, so it tracks the release automatically) and work outside a project. - Bump actions/checkout, actions/upload-artifact and actions/download-artifact v4 -> v5 in the Release workflow; the v4 line runs on Node 20, which GitHub now forces onto Node 24 with a deprecation warning. v5 targets Node 24 natively. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, independent changes.
nr --versionnr --version(and-V) print the version and work anywhere, even outside a project (handled before task detection). The string comes fromCARGO_PKG_VERSION, so it tracksCargo.tomlautomatically — no second place to bump at release time. Onmainit currently printsnr 2.0.0.Release workflow: off the deprecated Node 20
GitHub is forcing
actions/*@v4(Node 20) onto Node 24 with a deprecation warning. Bumped the three official actions in.github/workflows/release.ymlto@v5, which target Node 24 natively:actions/checkout@v4→@v5actions/upload-artifact@v4→@v5actions/download-artifact@v4→@v5For the usage here (glob upload of one file per matrix target, download-all into
artifacts/), the v5 majors are drop-in.Tests
Adds a
--versionintegration test (asserts^nr X.Y.Zand that-Vmatches). Full suite: 14 unit + 24 integration tests pass;cargo fmt/clippyclean; binary unchanged in size.🤖 Generated with Claude Code