fix(sa3): use the monotonic audio-to-audio schedule - #320
Draft
ryanontheinside wants to merge 1 commit into
Draft
Conversation
Advance the managed fork pin to the current-main schedule correction, stacked on the TensorRT plugin compatibility commit. The SAME-L plugin revision is unchanged, so deployments reuse the decoder built by the parent pin PR rather than rebuilding it for this Python-only change. The schedule implementation is submitted upstream separately with credit to CJ Carr's original sa3-a2a-monotonic-schedule branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Advance DEMON's managed SA3 pin to the monotonic audio-to-audio schedule branch being reviewed upstream in Stability-AI/stable-audio-3#94.
This is intentionally a one-line pin change. The sampler correction, regression tests, and CJ Carr attribution live in the upstream branch rather than in a DEMON-local shim.
Pinned combined test commit:
960da1f8cbe205ab3b702edbfabd91113ab22473.That fork commit contains:
Why it is stacked
Depends on DEMON #319, which establishes the current-upstream pin and versioned SAME-L engine boundary. Keeping this separate makes the source refresh independently reviewable and prevents the sampler fix from being confused with engine migration work.
Engine impact
No engine rebuild is required after #319. The schedule is Python/host-side and this pin retains the same explicit SAME-L plugin revision, so it discovers and reuses:
Existing DiT engines are also unchanged.
Verification
Against the combined fork branch:
Representative schedules at
sigma_max=0.1, 0.25, 0.5, 0.75, 1.0were checked for:At
sigma_max=0.5, the current schedule begins[0.50000, 0.70562, ...]; the corrected schedule begins[0.50000, 0.48849, ...].Merge instructions
main; its final diff should remain only the SA3 SHA change.Not included
The nonlinear product remapping of the denoise knob is deliberately excluded and lives in a separate dependent PR.