chore: import ADK plugin#6
Merged
Merged
Conversation
There was a problem hiding this comment.
14 issues found across 14 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/adk-plugin/tests/test_tools.py">
<violation number="1" location="packages/adk-plugin/tests/test_tools.py:21">
P2: Tests are coupled to real Daytona infrastructure without a credential/availability gate, so default test runs can fail when `DAYTONA_API_KEY` or backend access is missing.</violation>
<violation number="2" location="packages/adk-plugin/tests/test_tools.py:330">
P3: `test_execute_command_tool_declaration` verifies `command`, `cwd`, and `env` in properties but omits `timeout` — the declaration does include `timeout`. A change that removes or renames `timeout` from the declaration would go undetected.</violation>
<violation number="3" location="packages/adk-plugin/tests/test_tools.py:339">
P3: Only `test_execute_code_tool_declaration` asserts on `required`. The other four declaration tests (`ExecuteCommandTool`, `UploadFileTool`, `ReadFileTool`, `StartLongRunningCommandTool`) skip `required` verification entirely, making them unable to catch regressions where a required field is accidentally made optional.</violation>
</file>
<file name="packages/adk-plugin/daytona_adk/tools.py">
<violation number="1" location="packages/adk-plugin/daytona_adk/tools.py:60">
P2: `language` is incorrectly marked required despite having a default. Calls relying on default python will be rejected by schema validation.</violation>
<violation number="2" location="packages/adk-plugin/daytona_adk/tools.py:90">
P2: Temporary script path is not unique per execution, so concurrent JS/TS runs can race on the same file.</violation>
</file>
<file name="packages/adk-plugin/examples/file_operations.py">
<violation number="1" location="packages/adk-plugin/examples/file_operations.py:38">
P2: The embedded Python script content is indented, which can make the uploaded `/tmp/analysis.py` invalid at top level (`unexpected indent`).</violation>
</file>
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
eb08cc4 to
e047cb8
Compare
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
e047cb8 to
8f663e9
Compare
mislavivanda
added a commit
that referenced
this pull request
Jul 6, 2026
Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Introduce
daytona-adkv0.1.0 to let Google ADK agents run code and commands in Daytona sandboxes. Adds a plugin, tools, examples, and tests for the first Apache-licensed release.New Features
daytona-adk(packages/adk-plugin) withpyproject.toml, Apache 2.0LICENSE, README, and version0.1.0.DaytonaPlugincreates one sandbox and provides tools to run code (Python/JS/TS), execute commands, upload/read files, and start long-running processes; includes lifecycle hooks and cleanup.api_key,sandbox_name,env_vars,labels,auto_stop_interval,auto_delete_interval. Examples for App/Runner patterns, multi-language execution, file operations, and long-running processes. Unit tests included. Depends ongoogle-adkanddaytona.Migration
pip install daytona-adk.DAYTONA_API_KEY,GOOGLE_API_KEY.DaytonaPlugin(), passtools=plugin.get_tools()to your agent andplugins=[plugin]to yourApporInMemoryRunner.Written for commit 8f663e9. Summary will update on new commits.