Skip to content

chore: fixed XO warning #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2025
Merged

chore: fixed XO warning #5523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3e2ce9
chore: fixed XO warning
mfranzke Nov 26, 2025
ec008cc
Merge branch 'main' into chore-corrected-import
mfranzke Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storybooks/angular-storybook/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { StorybookConfig } from '@storybook/angular';
import { type StorybookConfig } from '@storybook/angular';
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax import { type StorybookConfig } is inconsistent with all other storybook configuration files in the repository. All other main.ts files in storybooks use import type { StorybookConfig } instead:

  • storybooks/_storybook/.storybook/main.ts: import type { StorybookConfig }
  • storybooks/react-storybook/.storybook/main.ts: import type { StorybookConfig }
  • storybooks/vue-storybook/.storybook/main.ts: import type { StorybookConfig }

Both syntaxes are valid TypeScript, but for consistency with the rest of the storybook files, please use import type { StorybookConfig } instead of import { type StorybookConfig }.

Suggested change
import { type StorybookConfig } from '@storybook/angular';
import type { StorybookConfig } from '@storybook/angular';

Copilot uses AI. Check for mistakes.

import { dirname, join } from 'node:path';

Expand Down
Loading