fix: resolve typecheck failures in .load command and tests utils#251
Merged
fix: resolve typecheck failures in .load command and tests utils#251
.load command and tests utils#251Conversation
|
Findings (blocking)
Missing tests / edge cases
Everything else in this PR is fine; the Residual risk: If you choose the “return |
|
No correctness, security, or regression issues found in the actual diff. Notes:
Tests: No additional tests seem necessary for this change. |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.loadspecial command returned a value despite being annotated-> None, and tests included an unused# type: ignoresuppression.Description
return [(None, None, None, "")]fromload_extensioninlitecli/packages/special/dbcommands.pyand removed the unused# type: ignore[attr-defined]comment fromtests/utils.py.Testing
pip install -e ., ranruff check litecli/packages/special/dbcommands.py tests/utils.pywhich passed, and ranpytest -q tests/test_dbspecial.pywhich completed successfully (9 passed); attemptedty checkbut thetytool was not available in the environment.Codex Task