Skip to content

Iterate on Codex label action#1578

Merged
rolandwalker merged 1 commit intomainfrom
RW/codex-review-on-label-try-again-03
Feb 17, 2026
Merged

Iterate on Codex label action#1578
rolandwalker merged 1 commit intomainfrom
RW/codex-review-on-label-try-again-03

Conversation

@rolandwalker
Copy link
Contributor

Description

With the correct operators, limiting to

github.event.action == 'labeled'

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

with the correct operators, limiting to

    github.event.action == 'labeled'
@rolandwalker rolandwalker self-assigned this Feb 17, 2026
@github-actions
Copy link

Findings

  1. Behavioral regression for draft PRs
    For draft PRs, the job now only runs on the labeled action, even if the codex label is already present. This means subsequent events like synchronize or ready_for_review won’t trigger the job anymore, which is a regression compared to prior behavior. If the intent was to allow label-gated runs on any action (while draft), the new condition is too narrow.
    File: .github/workflows/codex-review.yml

Suggestions

  1. If you meant “only when labeled” for drafts, consider explicitly scoping the workflow on: to pull_request with types: [labeled] for clarity and avoid missing other events inadvertently. Otherwise, restore the previous label check without the action == 'labeled' gating.

@rolandwalker rolandwalker merged commit 2fc2798 into main Feb 17, 2026
10 checks passed
@rolandwalker rolandwalker deleted the RW/codex-review-on-label-try-again-03 branch February 17, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant