Liberally accept literal DSN arguments to --dsn#1589
Merged
rolandwalker merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
|
Findings
No security issues or correctness regressions jumped out in the code paths touched. Suggested next steps
|
rolandwalker
force-pushed
the
RW/accept-literal-dsns-along-with-aliases
branch
2 times, most recently
from
9505a68 to
1774657
Compare
scottnemes
reviewed
Feb 20, 2026
mycli/main.py
Outdated
| @click.option("--list-dsn", "list_dsn", is_flag=True, help="list of DSN configured into the [alias_dsn] section of myclirc file.") | ||
| @click.option("-D", "--database", "dbname", help="Database or DSN to use for the connection.") | ||
| @click.option("-d", "--dsn", 'dsn_alias', default="", envvar="DSN", help="DSN alias configured in the ~/.myclirc file, or a full DSN.") | ||
| @click.option("--list-dsn", "list_dsn", is_flag=True, help="list of DSNs configured in the [alias_dsn] section of the ~/.myclirc file.") |
Contributor
There was a problem hiding this comment.
Maybe change the help to "list of DSN aliases..." to fit with your rename
Contributor
There was a problem hiding this comment.
Also maybe add an alias command for --list-dsn-aliases or something again to fit with your rename.
Contributor
There was a problem hiding this comment.
Also maybe add a --dsn-alias alias as well.
Contributor
Author
There was a problem hiding this comment.
Good point on the help text, will do!
But as to the other two, it isn't a user-visible rename, just a fallback, with an internal variable rename for clarity.
scottnemes
approved these changes
Feb 20, 2026
Contributor
scottnemes
left a comment
scottnemes
left a comment
There was a problem hiding this comment.
Verified it works as-is. Left some comments for further potential aliases if desired.
rolandwalker
force-pushed
the
RW/accept-literal-dsns-along-with-aliases
branch
from
1774657 to
77bc723
Compare
Forgive the user for thinking that --dsn can accept a literal DSN in addition to an alias. Internally, recast the confusing variable name "dsn" to "dsn_alias".
rolandwalker
force-pushed
the
RW/accept-literal-dsns-along-with-aliases
branch
from
77bc723 to
1d7c207
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forgive the user for thinking that
--dsncan accept a literal DSN in addition to an alias.Internally, recast the confusing variable name
dsntodsn_alias.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).