Let --ssl_mode=auto prefer SSL only for TCP/IP#1600
Merged
rolandwalker merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
|
Findings
Tests
No security concerns found. |
Contributor
Author
|
I think bot's suggestion 1 is wrong, and I'm not concerned about the interaction with the deprecated |
scottnemes
approved these changes
Feb 22, 2026
Contributor
scottnemes
left a comment
There was a problem hiding this comment.
Yeah according to "experts" SSL isn't needed for a socket connection, so makes sense for that. Likely little impact in reality for our use case, but since it's a fairly straightforward fix then might as well.
Verified SSL is no longer used when connecting via socket and ssl-mode=auto and SSL is used with socket and ssl-mode=on.
While it is _possible_ to negotiate an SSL connection to MySQL over a local socket, it shouldn't be needed (should it?). Nothing is transmitted over a network in that scenario. If the user still does need SSL/TLS, --ssl-mode=on is available to force it.
3f7f9b8 to
b72d325
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While it is possible to negotiate an SSL connection to MySQL over a local socket, it shouldn't be needed (should it?).
Nothing is transmitted over a network in that scenario.
If the user still does need SSL/TLS,
--ssl-mode=onis available to force it.@scottnemes does this PR make sense? I'm open to being convinced otherwise. It just made sense to me. (There could even be a fourth ssl_mode but that seemed like needless complexity.)
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).