fzf search: ensure fullscreen with preview on#1630
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Conversation
|
Findings
Missing tests / edge cases
If you want, I can draft a minimal test that validates the options list without invoking fzf. |
3 tasks
overriding environment variable FZF_DEFAULT_OPTS in part. The mycli documentation describes the fzf search as fullscreen with a preview; these options selectively override parts of FZF_DEFAULT_OPTS from the environment to make sure that is always true. The user's fzf keybindings, colors, and most other options are still taken from FZF_DEFAULT_OPTS if present.
4d673f3 to
b4be456
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fzf search: ensure fullscreen with preview on, overriding environment variable
FZF_DEFAULT_OPTSin part.The mycli documentation describes the fzf search as fullscreen with a preview; these options selectively override parts of
FZF_DEFAULT_OPTSfrom the environment to make sure that is always true.The user's fzf keybindings, colors, and most other options are still taken from
FZF_DEFAULT_OPTSif present.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).