Skip to content

Use prompt_toolkit's bell()#1649

Merged
rolandwalker merged 1 commit intomainfrom
RW/use-prompt-toolkit-bell
Feb 28, 2026
Merged

Use prompt_toolkit's bell()#1649
rolandwalker merged 1 commit intomainfrom
RW/use-prompt-toolkit-bell

Conversation

@rolandwalker
Copy link
Contributor

Description

This works the same way, but since we use prompt_toolkit, already, we should take more advantage of what it has built in.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 28, 2026
@github-actions
Copy link

Findings
No correctness or security issues found in the PR diff.

Test Gaps / Edge Cases

  1. Missing regression test for the new bell path at mycli/main.py:1004.
    Add a test that exercises beep_after_seconds > 0 and verifies the prompt-toolkit bell call is used (or at least that the path executes without error).

Assumptions

  • self.prompt_app is always initialized before this branch runs inside run_cli().

Change Summary

  • Replaced custom bell implementation with prompt_toolkit output bell call.
  • Removed dead MyCli.bell() helper and updated changelog.

This works the same way, but since we use prompt_toolkit, already, we
should take more advantage of what it has built in.
@rolandwalker rolandwalker force-pushed the RW/use-prompt-toolkit-bell branch from 874a7a1 to 2941df9 Compare February 28, 2026 11:54
@rolandwalker rolandwalker merged commit 6db6cf5 into main Feb 28, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/use-prompt-toolkit-bell branch February 28, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants