Improve refresh/reset completions checks#1770
Merged
rolandwalker merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
Codex Review
No security issues found in this diff. |
scottnemes
approved these changes
Apr 3, 2026
* need_completion_reset() should check for \r and connect * both functions should continue through exceptions in the case that one query cannot be parsed. We would ultimately fall back to False if no queries could be parsed.
52dad9c to
2df86bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
need_completion_reset()should check for\randconnectFalseif no queries could be parsed.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).