Skip to content

Add missing @dbtest test-skip rules #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolandwalker merged 1 commit into from
Apr 3, 2026
Merged

Add missing @dbtest test-skip rules #1804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Internal
* Refactor suggestion logic into declarative rules.
* Factor the `--batch` execution modes out of `main.py`.
* Sort coverage report in tox suite.
* Skip more tests when a database connection is not present.


1.67.1 (2026/03/28)
Expand Down
3 changes: 3 additions & 0 deletions test/pytests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,13 @@ def test_select_from_empty_table(executor):
assert expected in result.output


@dbtest
def test_is_valid_connection_scheme_valid(executor, capsys):
is_valid, scheme = is_valid_connection_scheme(f"mysql://test@{DEFAULT_HOST}:{DEFAULT_PORT}/dev")
assert is_valid


@dbtest
def test_is_valid_connection_scheme_invalid(executor, capsys):
is_valid, scheme = is_valid_connection_scheme(f"nope://test@{DEFAULT_HOST}:{DEFAULT_PORT}/dev")
assert not is_valid
Expand Down Expand Up @@ -2154,6 +2156,7 @@ def test_execute_arg_supersedes_batch_file(monkeypatch):
os.remove(batch_file.name)


@dbtest
def test_null_string_config(monkeypatch):
monkeypatch.setattr(MyCli, 'system_config_files', [])
monkeypatch.setattr(MyCli, 'pwd_config_file', os.devnull)
Expand Down
Loading