Rename MyCli prompt_app property to prompt_session#1819
Merged
rolandwalker merged 1 commit intomainfrom Apr 4, 2026
Merged
Conversation
Since this property contains a PromptSession instance, calling it a prompt_app was confusing, especially since "prompt_app" had itself a property named "app". No functional change. Incidentally removes _main_module() from main_modes/repl.py, since it is no longer used.
rolandwalker
force-pushed
the
RW/rename-prompt-app-property-to-prompt-session
branch
from
483c2c6 to
3656f34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since this property contains a
PromptSessioninstance, calling it aprompt_appwas confusing, especially sinceprompt_apphad itself a property namedapp.No functional change.
Incidentally removes
_main_module()frommain_modes/repl.py, since it is no longer used.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).