Move show_warnings from main.py to special/iocommands.py#1834
Merged
rolandwalker merged 1 commit intomainfrom Apr 11, 2026
Merged
Move show_warnings from main.py to special/iocommands.py#1834rolandwalker merged 1 commit intomainfrom
main.py to special/iocommands.py#1834rolandwalker merged 1 commit intomainfrom
Conversation
rolandwalker
force-pushed
the
RW/migrate-show-warnings-from-main-to-special
branch
from
a5c06e3 to
a8affb3
Compare
The globals may not be pretty, but the file location is more correct. The behavior of the CLI overriding the config file is preserved, but that logic is moved to MyCli construction instead of within connect(), which is also a better location for computing configuration. Some tangential tests are included since other regression tests are wholly deleted.
rolandwalker
force-pushed
the
RW/migrate-show-warnings-from-main-to-special
branch
from
a8affb3 to
8a70ca4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The globals may not be pretty, but the file location is more correct.
The behavior of the CLI overriding the config file is preserved, but that logic is moved to MyCli construction instead of within
connect(), which is also a better location for computing configuration.Some tangential tests are included since other regression tests are wholly deleted.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).