Don't persist password-change SQL statements to the history file#1835
Merged
rolandwalker merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
rolandwalker
force-pushed
the
RW/do-not-persist-password-changes-in-history
branch
from
139c530 to
42460af
Compare
scottnemes
reviewed
Apr 11, 2026
|
|
||
| history.append_string('SELECT 1') | ||
|
|
||
| assert history._loaded_strings[0] == 'SELECT 1' |
Contributor
There was a problem hiding this comment.
Could this (and the one below) use the public method get_strings() instead of this private method?
Contributor
Author
There was a problem hiding this comment.
Good point. Done!
scottnemes
approved these changes
Apr 11, 2026
Contributor
scottnemes
left a comment
scottnemes
left a comment
There was a problem hiding this comment.
Looks good overall; see the one comment if you want to address it.
Leveraging the new is_password_change() detection, avoid persisting password-change statements to the history file, but leave them available for navigation in the current session. Wrap the sqlglot.tokenize() call for is_password_change() in a try block, since it could throw if given invalid SQL. Add and improve tests for sql_utils.py.
rolandwalker
force-pushed
the
RW/do-not-persist-password-changes-in-history
branch
from
42460af to
75db244
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Leveraging the new
is_password_change()detection from #1829, avoid persisting password-change statements to the history file, but leave them available for navigation in the current session.Wrap the
sqlglot.tokenize()call foris_password_change()in atryblock, since it could throw if given invalid SQL.Add and improve tests for
sql_utils.py.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).