perf: skip LLM imports when MYCLI_LLM_OFF is set#1918
Merged
rolandwalker merged 1 commit intoJun 6, 2026
Merged
Conversation
rolandwalker
reviewed
Jun 6, 2026
| @@ -1,3 +1,5 @@ | |||
| import os as _os | |||
Contributor
Author
There was a problem hiding this comment.
It's unnecessary. Simplified to import os. Thanks!
Dragonliu2018
force-pushed
the
lzl/perf/skip-llm-imports-when-llm-off
branch
from
a336a0e to
c1b31bd
Compare
rolandwalker
approved these changes
Jun 6, 2026
Contributor
|
Great catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
special/__init__.pyunconditionally imported LLM symbols on every startup, pulling in the entireopenaipackage even when LLM features are unused.llm.pyandmain.pyalready guarded their imports withMYCLI_LLM_OFF, but__init__.pybypassed that protection.This PR brings
__init__.pyin line with the rest: whenMYCLI_LLM_OFF=1, LLM imports are skipped and lightweight stubs are provided instead, reducing startup time.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).