Smart completion tests#4
Closed
j-bennet wants to merge 8 commits into
Closed
Conversation
Member
|
Thanks for adding the tests. I might squash them into a single commit before merging it in. |
Contributor
Author
|
How do I do that?
|
Member
|
If you'd like to do it, you can issue: That'll pop you into an editor. Then you can squash the commits by changing the word Then it'll squash the commits into a single commit and you'll get a chance to change the commit message. Then you'll have to force push that new commit to your repo. |
Member
|
I've cherry picked the commit that adds the smart_completion tests. Thank you for the PR. 🍰 |
koljonen
added a commit
to koljonen/pgcli
that referenced
this pull request
Mar 5, 2017
DiegoDAF
added a commit
to DiegoDAF/pgcli.daf
that referenced
this pull request
Jul 20, 2026
Port of the review feedback on upstream PR dbcli#1544. Instead of checking self.force_destructive at both call sites (execute_from_file and execute_command), confirm_destructive_query now takes a `force` parameter and owns the whole "should we proceed?" decision: non-destructive -> None force -> True non-tty stdin -> None (no prompt) otherwise -> prompt the user Behaviour is unchanged. The parameter defaults to False, so existing callers are unaffected. The only remaining self.force_destructive reference is the guard that suppresses the "Your call!" message, which is about output, not the proceed/abort decision. Also closes roadmap item dbcli#4 (Conexiones) in todo.md as redundant: post-connect SQL and .pg_service.conf already exist, keepalives/connect_timeout already work via the connection string, and SSL ~ expansion has no practical need. No version bump (held at 4.5.7 per Diego).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some tests for smart completion.