Conversation
Example : - if this option is set to false Foo.h will be marked as used if a Foo.xib reference the Foo class - else if this option is set to true Foo.h will be marked as unused even if a Foo.xib reference the class (and if there is no other reference to Foo.h...)
Example : - if this option is set to false Foo.h will be marked as used if a Foo.xib reference the Foo class - else if this option is set to true Foo.h will be marked as unused even if a Foo.xib reference the class (and if there is no other reference to Foo.h...)
|
|
||
| pre do |global_options, command, options, args| | ||
| $fui = Fui::Finder.new(global_options[:path]) | ||
| $fui = Fui::Finder.new(global_options[:path], global_options[:excludeselfxib]) |
There was a problem hiding this comment.
Should refactor Finder#initialize to be (path, options = {}) because path is required, but the rest is not, and just pass global_options in without path.
There was a problem hiding this comment.
As i said, i'm an noobie in Ruby, how can i pass global_options without path ?
There was a problem hiding this comment.
options = global_options.dup
path = options.delete(:path)
Fui::Finder.new(path, options)
|
This is great, my comments aren't "must haves", but I'd appreciate if you could address all/some/none of them. LMK. Squash your commits, too. |
|
This also needs a README update. |
|
Thanks, i'm a noobie in Ruby, i'm not sure to be able to address all comments but i will try ! |
|
I just push a new commit with some of your suggestions. |
|
The extracting that This is great, merging. |
Added --excludeselfxib. Example : - if this option is set to false Foo.h will be marked as used if a Foo.xib reference the Foo class - else if this option is set to true Foo.h will be marked as unused even if a Foo.xib reference the class (and if there is no other reference to Foo.h...)
|
Thanks 👍 |
|
I renamed |
|
Well it's a little bit confusing because it's not ignoring all XIB but only the XIB with the same name of its class but it's not a big deal ! |
|
I thought about that, but I think the doc is clear and if it were to ignore all XIBs it would be called |
|
I released 0.4.0 with your feature, thank you! |
|
Yep you are right, thanks a lot |
2 participants
Sometimes you want to find if a class is unused even if it is referenced from its self XIB, the "excludeselfxib" option handle this case.
Example :