Feature/adding support for ignoring bridging headers#32
Merged
dblock merged 18 commits intodblock:masterfrom Dec 17, 2018
Merged
Conversation
…port <Framework/Header.h>)
Updating tests to pass for new switch names.
…rtForIgnoringPaths # Conflicts: # README.md # bin/fui # lib/fui/finder.rb # spec/fui/finder_spec.rb
…rtForIgnoringBridgingHeaders # Conflicts: # .rubocop.yml # .rubocop_todo.yml # CHANGELOG.md # README.md # lib/fui/finder.rb
Owner
|
👍 |
jeffctown
deleted the
feature/AddingSupportForIgnoringBridgingHeaders
branch
jeffctown
added a commit
to jeffctown/fui
that referenced
this pull request
Dec 17, 2018
jeffctown
added a commit
to jeffctown/fui
that referenced
this pull request
Dec 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I keep getting false positives on bridging headers in projects that have a mix of Objective C and Swift. This PR is to add support for removing bridging headers from results. This code looks through *.pbxproj files in the supplied path to find the lines that match
SWIFT_OBJC_BRIDGING_HEADER = "BridgingHeaderSpec-Bridging-Header.h";.I also added lots of lint fixes / comments.