Fix ArgumentError: invalid byte sequence in UTF-8 for non-UTF-8 files#47
Merged
Fix ArgumentError: invalid byte sequence in UTF-8 for non-UTF-8 files#47
Conversation
…-UTF-8 files Files with non-UTF-8 encoding (e.g., GB2312/GB18030 commonly used in Chinese codebases) would cause an ArgumentError when fui tried to match import patterns against file contents. Read files in binary mode and transcode to UTF-8, replacing invalid byte sequences. This allows fui to gracefully handle files with any encoding while still finding #import references. Fixes #37. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Danger ReportNo issues found. |
Owner
Author
|
Looks similar to #39. |
This was referenced Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37.
Problem
Files with non-UTF-8 encoding (e.g., GB2312/GB18030 commonly used in Chinese codebases on Windows) caused
ArgumentError: invalid byte sequence in UTF-8when fui tried to match import patterns against file contents.Fix
Read files in binary mode and transcode to UTF-8, replacing any invalid byte sequences. This allows fui to gracefully handle files with any encoding while still correctly finding
#importreferences.Changes
lib/fui/finder.rb: Read files as binary then encode to UTF-8 (replacing invalid bytes) inprocess_codeandprocess_xml. Also removed the unnecessaryFile.openwrapper sinceFile.readwas re-opening the file anyway.spec/fui/finder_spec.rb: Added test cases for non-UTF-8 encoded files.spec/fixtures/non_utf8/: Added fixture files including a.mfile with GB2312-encoded bytes (invalid UTF-8).