Fix NameError: undefined local variable or method 'project_path' in verbose mode#48
Merged
Fix NameError: undefined local variable or method 'project_path' in verbose mode#48
Conversation
…erbose mode In verbose mode, Fui::Project#bridging_headers referenced `project_path` which does not exist. The correct method is `path`, already available as an attr_accessor on the instance. Fixes #42. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Danger ReportNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42.
Problem
Running fui with
--verboseraised aNameError: undefined local variable or method 'project_path'when a bridging header was found. The code inFui::Project#bridging_headersreferencedproject_pathwhich doesn't exist.Fix
Replace
project_pathwithpath, which is already available as anattr_accessoron the instance.Changes
lib/fui/project.rb: Replaceproject_pathwithpathon line 25.spec/fui/project_spec.rb: Added a test forbridging_headersin verbose mode.