Fix delete command to also remove .mm implementation files#50
Merged
Conversation
The delete command only looked for .m implementation files when deleting an unused header, missing .mm (Objective-C++) files in mixed projects. Also updated the prompt text from (.m) to (.m/.mm). Fixes #12. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
fix/delete-mm-files
branch
from
a975773 to
95fec9f
Compare
Danger ReportNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Problem
The
deletecommand only looked for.mimplementation files when removing an unused header. In projects with Objective-C++ (.mm) files, the implementation file would be left behind.Changes
.mand.mmextensions when looking for implementation files to delete(.m)to(.m/.mm).mmcase (simulation and--perform)