More descriptive naming in UriPolicy (#130) #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me. Maybe we should rename the "activeFor" parameters to "applicableFor" or "applicableTo" to be consistent with PolicyApplicable? |
jcsahnwaldt
added a commit
that referenced
this pull request
Dec 3, 2013
More descriptive naming in UriPolicy (#130)
jimkont
pushed a commit
to jimkont/extraction-framework
that referenced
this pull request
Mar 26, 2015
More descriptive naming in UriPolicy (dbpedia#130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming in UriPolicy is kind of confusing,
this commits provides more descriptive names in types, functions and variables