fixed issue with WikiDownloader.scala caused by api change in mediawiki #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 |
jimkont
added a commit
that referenced
this pull request
Feb 17, 2016
fixed issue with WikiDownloader.scala caused by api change in mediawiki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue reported by Dimitris
This issue was caused due to an undocumented change in the mediawiki api, at some point in time they changed the api argument "gapfrom" to "gapcontinue" , this was however never documented [1].
This change should fix the WikiDownloader.scala crashing, however I'm not confident that other problems won't arise. This patch needs to be further tested in on the server.
[1] https://www.mediawiki.org/wiki/API:Query