Skip to content

change event handlers to (event, datum) #1829

@gordonwoodhull

Description

@gordonwoodhull

d3compat.eventHandler currently takes a function(datum, event) for trivial adaptation of old event handlers.

However, to reduce confusion and facilitate eventual removal of d3@5 compatibility, I think these should use the d3@6 signature.

Of course, we might not get to it until then; if not, this is documentation. It's something I noticed when working on #1824 when fixing tests to call consistently with the active version of d3. d3compat.callHandler takes a function(event, datum)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions