Full range check in rest of API - #216
Merged
Merged
Conversation
Check ranges and error on incorrect ones in constructors and setters in all spots. Additional non-deserialization test checks to check the above. Migrate few remaining usage of `JsValue` for WASM errors away to `JsError` to be consistent with the rest of the generated code.
…this is not recently changed code)
gostkin
approved these changes
Dec 12, 2023
SebastienGllmt
pushed a commit
that referenced
this pull request
Aug 18, 2026
* Full range check in rest of API Check ranges and error on incorrect ones in constructors and setters in all spots. Additional non-deserialization test checks to check the above. Migrate few remaining usage of `JsValue` for WASM errors away to `JsError` to be consistent with the rest of the generated code. * fixed clippy warnings (did cargo update? doesn't trigger locally and this is not recently changed code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check ranges and error on incorrect ones in constructors and setters in all spots.
Additional non-deserialization test checks to check the above.
Migrate few remaining usage of
JsValuefor WASM errors away toJsErrorto be consistent with the rest of the generated code.